Fix minimal-versions CI failure after codspeed removal#760
Merged
samueltardieu merged 1 commit intomainfrom Mar 10, 2026
Merged
Fix minimal-versions CI failure after codspeed removal#760samueltardieu merged 1 commit intomainfrom
samueltardieu merged 1 commit intomainfrom
Conversation
Copilot
AI
changed the title
[WIP] Remove codspeed from CI and benchmarks
Remove CodSpeed; use criterion directly in benchmarks
Mar 10, 2026
📊 iai-callgrind Benchmark Results✅ 1 Improvement(s)| Benchmark | Base | PR | Change | % | ➡️ 19 Unchanged (within ±0.1%)Click to expand
iai-callgrind measures instructions executed, which is deterministic and not affected by system load. |
📊 iai-callgrind Benchmark Results➡️ 20 Unchanged (within ±0.1%)Click to expand
✅ All benchmarks unchangediai-callgrind measures instructions executed, which is deterministic and not affected by system load. |
Copilot
AI
changed the title
Remove CodSpeed; use criterion directly in benchmarks
Fix minimal-versions CI failure after codspeed removal
Mar 10, 2026
Co-authored-by: samueltardieu <44656+samueltardieu@users.noreply.github.com>
samueltardieu
force-pushed
the
copilot/remove-codspeed-from-ci
branch
from
9a5a00e to
94acc90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing
codspeed-criterion-compatdropped the implicitregexfloor, causing-Zminimal-versionsto resolveregextov1.5.0which no longer compiles with current Rust.Changes
Cargo.toml: Re-addregex = "1.11.3"as a dev-dependency floor to prevent-Zminimal-versionsfrom selecting a brokenregexversion. This is a transitive constraint viacriterion 0.5, not a direct use.copilot-instructions.md: Document the minimal-versions test workflow in Essential Commands, Critical Validation Rules, and Common Pitfalls — including the pattern of needing explicit floor entries for troublesome transitive dependencies.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.